Conversation
FORK=1 is needed to know whether the nacl-vms target has been created already.
|
Also this fixes another regression that you can't build the sgame and cgame DLLs/exes at the same time... |
| endif() | ||
|
|
||
| if (FORK EQUAL 1) | ||
| if (NOT FORK) # create the nacl-vms target only the first time that GAMEMODULE is called |
There was a problem hiding this comment.
You don't need to set the PARENT_SCOPE if you do:
if (FORK EQUAL 1 AND NOT TARGET nacl-vms)There was a problem hiding this comment.
In fact that would activate the following else() so it's wrong if exactly done this way.
|
Well I tried to preserve your notion of making it extensible to multiple gamelogic toolchains with multiple sub-invocations. But if you don't care about that now we could check just |
|
Instead of |
|
Bored of bikeshedding now |
|
It was not a suggestion to do this in this PR anyway (it would break the docker release script if I'm right), just me sharing some thoughts on what we may do in the future. |
2 participants
FORK=1 is needed to know whether the nacl-vms target has been created already.